Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore making the GitLab runner cypress tests instead of jest #72

Closed
Racer159 opened this issue Apr 8, 2024 · 2 comments · Fixed by #73
Closed

Explore making the GitLab runner cypress tests instead of jest #72

Racer159 opened this issue Apr 8, 2024 · 2 comments · Fixed by #73

Comments

@Racer159
Copy link
Contributor

Racer159 commented Apr 8, 2024

Describe what should be investigated or refactored

Our current journey tests are written in jest but it may be nicer to explore cypress to be able to navigate the web interface of GitLab and ensure that it also works correctly. cypress may also make the waits and retries easier as well.

Links to any relevant code

https://github.com/defenseunicorns/uds-package-gitlab-runner/tree/main/test

Additional context

This came out of reflections for how this works with GitLab and the decode slashes issues here: defenseunicorns/uds-core#288

@zachariahmiller
Copy link
Contributor

Or playwright?

@zachariahmiller
Copy link
Contributor

Additional context on above. UDS Core team is currently using cypress for things ( i think just keycloak) after running into issues trying to use playwright with custom certs. My understanding is the pivot to cypress was just in the interest of time, not necessarily based on merits. It sounds like for now those test are very limited integration tests and there are discussions around doing more indepth testing (MFA, email verification, etc) at which time they will probably reevaluate playwright.

We could probably take the same approach here. On the other hand, we could maybe take a stab at getting playwright working in the first place with the custom certs and evaluate since we will probably have more of this type of testing that we need to do across SWF applications.

Racer159 added a commit that referenced this issue Apr 10, 2024
## Description

This improves the patterns for running jest tests for GLR - we decided
against cypress and playwright because both run the tests in browser and
cannot make use of spawnSync or KFC.

## Related Issue

Fixes #72 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab-runner/blob/main/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: Billy Figueroa <figuer25@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants