Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add netpols and monitoring #81

Merged
merged 8 commits into from
May 16, 2024
Merged

feat!: add netpols and monitoring #81

merged 8 commits into from
May 16, 2024

Conversation

zachariahmiller
Copy link
Contributor

@zachariahmiller zachariahmiller commented May 11, 2024 •
edited by Racer159
Loading

Description

...

Related Issue

Fixes #76

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@zachariahmiller zachariahmiller requested a review from a team as a code owner May 11, 2024 01:39
@zachariahmiller zachariahmiller marked this pull request as draft May 11, 2024 01:40
@zachariahmiller zachariahmiller marked this pull request as ready for review May 13, 2024 18:11
Racer159
Racer159 reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me locally but had the following comments

chart/templates/uds-package-sandbox.yaml Outdated Show resolved Hide resolved
chart/templates/uds-package-sandbox.yaml Outdated Show resolved Hide resolved
chart/templates/uds-package-sandbox.yaml Outdated Show resolved Hide resolved
@Racer159 Racer159 changed the title feat: add netpols and monitoring feat!: add netpols and monitoring May 15, 2024
Racer159
Racer159 reviewed May 15, 2024
View reviewed changes
values/common-values.yaml Outdated Show resolved Hide resolved
@zachariahmiller @Racer159
Apply suggestions from code review
8ea0cbc 
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Racer159
Racer159 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zachariahmiller zachariahmiller merged commit 71c40fb into main May 16, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request May 16, 2024
Merged
Racer159 pushed a commit that referenced this pull request May 29, 2024
@github-actions
chore(main): release 17.0.0-uds.0 (#83)
246cfc0 
🤖 I have created a release *beep* *boop*
---


##
[17.0.0-uds.0](v16.11.0-uds.0...v17.0.0-uds.0)
(2024-05-29)


### ⚠ BREAKING CHANGES

* add netpols and monitoring
([#81](#81))

### Features

* add netpols and monitoring
([#81](#81))
([71c40fb](71c40fb))


### Miscellaneous

* **deps:** update gitlab runner package dependencies
([#80](#80))
([8393282](8393282))
* **deps:** update gitlab runner support dependencies
([#78](#78))
([a203bac](a203bac))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@blancharda blancharda mentioned this pull request Jun 13, 2024
Merged
@blancharda blancharda mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

Assignees
No one assigned
Labels
breaking-change 💔
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the config chart to template out the netpol generation section of the uds-package cr.
2 participants
@zachariahmiller @Racer159