-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add basic smoke tests with sso, git commit, and file uploads #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall007
commented
May 23, 2024
marshall007
commented
May 23, 2024
Racer159
previously approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had nits but this is good to go (code wise)
6f33a97
to
1f020f6
Compare
Racer159
approved these changes
May 24, 2024
1f020f6
to
02f0974
Compare
Racer159
pushed a commit
that referenced
this pull request
May 24, 2024
🤖 I have created a release *beep* *boop* --- ## [17.0.1-uds.0](v16.11.1-uds.1...v17.0.1-uds.0) (2024-05-24) ### Bug Fixes * correct `objectStorage` secret Helm value key for toolbox backups ([366c703](366c703)) ### Miscellaneous * add basic smoke tests with sso, git commit, and file uploads ([#132](#132)) ([2c34cf9](2c34cf9)), closes [#130](#130) * address prod issues with gitlab ([#131](#131)) ([ddea7ff](ddea7ff)) * cleanup dev secrets to remove postgres refs ([#126](#126)) ([430ebba](430ebba)) * **deps:** update gitlab package dependencies ([#121](#121)) ([366c703](366c703)) * **deps:** update gitlab support dependencies ([#123](#123)) ([8ecd5b4](8ecd5b4)) * update dev-secrets to use vendored kubectl command ([#129](#129)) ([eb7f356](eb7f356)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130