Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change to use uds-common pr workflow #63

Merged
merged 11 commits into from
Mar 12, 2024

Conversation

ericwyles
Copy link
Contributor

@ericwyles ericwyles commented Mar 8, 2024

Description

Updated the test workflow to use new test action from uds-common

Updated other uds-common references to the latest version.

Refactored the way PR workflow was being triggered to match other swf packages.

Related Issue

Relates to defenseunicorns/uds-software-factory#17
Also solves #57

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@ericwyles ericwyles changed the title change to use uds-common pr workflow chore: change to use uds-common pr workflow Mar 8, 2024
@ericwyles ericwyles self-assigned this Mar 12, 2024
@ericwyles ericwyles marked this pull request as ready for review March 12, 2024 14:40
@ericwyles ericwyles requested a review from a team as a code owner March 12, 2024 16:59
@naveensrinivasan naveensrinivasan mentioned this pull request Mar 12, 2024
5 tasks
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review before mtg.

.github/workflows/tag-and-release.yaml Outdated Show resolved Hide resolved
.github/workflows/tag-and-release.yaml Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of comments

.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
tasks.yaml Show resolved Hide resolved
@ericwyles ericwyles added this to the runchecks milestone Mar 12, 2024
@ericwyles ericwyles requested a review from Racer159 March 12, 2024 21:21
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/defenseunicorns/uds-package-gitlab/blob/ewyles-consolidate-workflows/.github/workflows/ci-docs-shim.yaml The shim job name will need to be updated to match the new name of the required checks

@zachariahmiller
Copy link
Contributor

@ericwyles The required checks have been updated to match the new names. The doc shim workflow will need the names updated to match though. If you can fix that i think this is good to go.

@ericwyles
Copy link
Contributor Author

@ericwyles The required checks have been updated to match the new names. The doc shim workflow will need the names updated to match though. If you can fix that i think this is good to go.

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants