-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change to use uds-common pr workflow #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review before mtg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/defenseunicorns/uds-package-gitlab/blob/ewyles-consolidate-workflows/.github/workflows/ci-docs-shim.yaml The shim job name will need to be updated to match the new name of the required checks
@ericwyles The required checks have been updated to match the new names. The doc shim workflow will need the names updated to match though. If you can fix that i think this is good to go. |
This should be fixed now. |
Description
Updated the test workflow to use new test action from uds-common
Updated other uds-common references to the latest version.
Refactored the way PR workflow was being triggered to match other swf packages.
Related Issue
Relates to defenseunicorns/uds-software-factory#17
Also solves #57
Type of change
Checklist before merging