-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Support of Mattermost plugins #7
Comments
This should be easy from a manual perspective. It does require one bundle override to enable plugin uploads: overrides:
mattermost-enterprise-edition:
values:
- path: "mattermostApp.extraEnv"
value:
- name: MM_PLUGINSETTINGS_ENABLEUPLOADS
value: "true" After that the plugin can be installed and enabled the same way the docs list - https://github.com/mattermost/mattermost-plugin-ai?tab=readme-ov-file#install For an automatic approach we should be able to use https://github.com/mattermost/mattermost-helm/blob/master/charts/mattermost-enterprise-edition/values.yaml#L206-L233 which shouldn't be too difficult until we assume airgap 🤪 |
Discovered in further testing that doing the above mentioned override will cause envs to get wiped out for other config (filestorage/sso). Resolving that in the linked PR, assuming that is merged the new way to approach will be: overrides:
mattermost:
uds-mattermost-config:
values:
- path: "config.enablePluginUploads"
value: "true" |
This is currently being done here and would likely be a sane default for this package: https://github.com/defenseunicorns/uds-prod-infrastructure/blob/dc5fa80ae403e376679f2b2c4e1bdca4cc0b1e05/bundles/swf/uds-bundle.yaml#L57 |
AI plugin can be the first plugin we do, but working this issue will allow us to solve a broader problem of how we handle mattermost plugins in the package vs the bundle. |
We should also check with @YrrepNoj to see how 🐸 is doing this today |
In a current environment running LFAI + MM we enabled plugin upload and then manually added the plugin (i.e. this was not an automated or airgapped process). |
We scoped this down a bit for clarity. The expectations for this ticket will be:
|
Yes we can enable plugins by default via via: https://docs.mattermost.com/configure/environment-variables.html
|
## Description This adds an `initContainer` used to sideload mattermost plugins. New plugins can be added by adding additional `ADD` commands to the included `Dockerfile`. ## Related Issue Fixes #7 Depends on defenseunicorns/uds-common#161 for renovate changes. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: zamaz <71521611+zachariahmiller@users.noreply.github.com>
Is your feature request related to a problem? Please describe.
Users of Mattermost will want to use plugins. Currently, whomever is managing Mattermost deployments would need to configure plugins manually, post-deployment.
Describe the solution you'd like
A way to manage Mattermost plugins via code at the package level vs bundle or manually.
Describe alternatives you've considered
Doing it manually
Additional context
🐸
https://github.com/mattermost/mattermost-plugin-ai
The text was updated successfully, but these errors were encountered: