feat: enable prometheus metrics to be Made for UDS #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this config: |
|
Now with
|
zachariahmiller
previously approved these changes
Jul 31, 2024
|
@Racer159 Instead of committing the svg to every repo can we just refer to the one in uds-common? That way if it changes it's a lot easier to update |
corang
requested changes
Jul 31, 2024
corang
approved these changes
Jul 31, 2024
zachariahmiller
approved these changes
Jul 31, 2024
Racer159
pushed a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- ## [7.2.6-uds.0](v7.2.5-uds.2...v7.2.6-uds.0) (2024-07-31) ### Features * enable prometheus metrics to be Made for UDS ([#28](#28)) ([a05f79e](a05f79e)) ### Miscellaneous * **deps:** update support-deps to v3.25.15 ([#26](#26)) ([c5ad30c](c5ad30c)) * **deps:** update valkey package dependencies ([#20](#20)) ([72e7bff](72e7bff)) * **deps:** update valkey package dependencies ([#29](#29)) ([770953b](770953b)) * **deps:** update valkey support dependencies ([#21](#21)) ([9c0040e](9c0040e)) * **deps:** update valkey support dependencies ([#27](#27)) ([7e1775a](7e1775a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the service monitor for Valkey to officially finish the Made for UDS journey.
Related Issue
Fixes #22
Type of change
Checklist before merging