Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] Refactor OCI to move it to common library #2251

Closed
AustinAbro321 opened this issue Jan 24, 2024 · 1 comment · Fixed by #2404
Closed

[Design] Refactor OCI to move it to common library #2251

AustinAbro321 opened this issue Jan 24, 2024 · 1 comment · Fixed by #2404
Assignees
@AustinAbro321
Labels
design openssf Issues needing to be completed before donation to OpenSSF tech-debt 💳 Debt that the team has charged and needs to repay
Milestone
(2024.02.20)

Comments

@AustinAbro321
Copy link
Contributor

AustinAbro321 commented Jan 24, 2024 •
edited by Racer159
Loading

Describe what should be investigated or refactored

Some of the code in src/pkg/oci should be refactored to be more generally usable by other projects. The functions will need to be generalized to work with generic OCI packages. The Zarf specific logic will need to be pulled out. The refactored generic OCI code will move to https://github.com/defenseunicorns/pkg.

To start this refactor we will need to create a design doc outlining the structure / goals of the changes. This should be done in a discussion outlined here: #2286
@AustinAbro321 AustinAbro321 changed the title Refactor: Move OCI to common library Refactor OCI to move it to common library Jan 24, 2024
@Racer159 Racer159 added the tech-debt 💳 Debt that the team has charged and needs to repay label Jan 24, 2024
@Racer159
Copy link
Contributor

We should ensure we add unit tests during this migration: #1750

@oates oates mentioned this issue Apr 29, 2023
Closed
@Racer159 Racer159 added this to the (2024.02.20) milestone Feb 2, 2024
@Racer159 Racer159 mentioned this issue Feb 2, 2024
Merged
5 tasks
@Racer159 Racer159 changed the title Refactor OCI to move it to common library [Design] Refactor OCI to move it to common library Feb 6, 2024
@Racer159 Racer159 added the design label Feb 6, 2024
@Noxsios Noxsios added the openssf Issues needing to be completed before donation to OpenSSF label Mar 18, 2024
@AustinAbro321 AustinAbro321 mentioned this issue Mar 26, 2024
Merged
5 tasks
Noxsios pushed a commit that referenced this issue Mar 28, 2024
@AustinAbro321
chore: switch to use oci lib in defenseunicorns/pkg (#2404)
08c92e1 
## Description

switch to using the oci library at
https://github.com/defenseunicorns/pkg. This would also close
#2392 as we pull in an
updated docker version

Fixes #2251

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AustinAbro321 AustinAbro321

Labels
design openssf Issues needing to be completed before donation to OpenSSF tech-debt 💳 Debt that the team has charged and needs to repay
Projects
No open projects
Zarf Project Board
Status: Closed
Milestone
(2024.02.20)
Development

Successfully merging a pull request may close this issue.

chore: switch to use oci lib in defenseunicorns/pkg defenseunicorns/zarf
3 participants
@Racer159 @AustinAbro321 @Noxsios