Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move helpers to common library #2252

Closed
AustinAbro321 opened this issue Jan 24, 2024 · 2 comments · Fixed by #2235 or defenseunicorns/pkg#30
Closed

Move helpers to common library #2252

AustinAbro321 opened this issue Jan 24, 2024 · 2 comments · Fixed by #2235 or defenseunicorns/pkg#30
Assignees
@Racer159
Labels
openssf Issues needing to be completed before donation to OpenSSF tech-debt 💳 Debt that the team has charged and needs to repay
Milestone
(2024.02.20)

Comments

@AustinAbro321
Copy link
Contributor

Describe what should be investigated or refactored

The code in src/pkg/utis/helpers will move to https://github.com/defenseunicorns/pkg. This should be simple as this package has no dependencies on anything in zarf.
@AustinAbro321 AustinAbro321 changed the title Refactor: Move helpers to common library Move helpers to common library Jan 24, 2024
@Racer159 Racer159 added the tech-debt 💳 Debt that the team has charged and needs to repay label Jan 24, 2024
@Racer159
Copy link
Contributor

Tying this issue to this issue since they might be handleable together: #2152

@Racer159
Copy link
Contributor

We should ensure we add unit tests during this migration: #1750

@Racer159 Racer159 added this to the (2024.02.20) milestone Feb 2, 2024
@AustinAbro321 AustinAbro321 mentioned this issue Feb 20, 2024
Merged
5 tasks
Racer159 added a commit that referenced this issue Mar 4, 2024
@AustinAbro321 @Noxsios
@lucasrod16 @Racer159
chore: refactor and purify the OCI library within Zarf. (#2235)
bc7987c 
## Description

Move OCI lib out, so it can be more easily used with other projects and
contributed to by multiple teams.

Fixes: #2252 #2288 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: razzle <harry@razzle.cloud>
Co-authored-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
@Noxsios Noxsios reopened this Mar 4, 2024
@Racer159 Racer159 mentioned this issue Mar 13, 2024
Merged
5 tasks
@Racer159 Racer159 assigned Racer159 and unassigned AustinAbro321 Mar 13, 2024
Noxsios pushed a commit that referenced this issue Mar 15, 2024
@Racer159 @AustinAbro321
refactor: split helpers/exec libs (#2379)
d0bcc20 
## Description

This moves more code into helpers / exec packages in preparation for
moving the actions/variables code.

## Related Issue

Relates to #2252

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
@Noxsios Noxsios added the openssf Issues needing to be completed before donation to OpenSSF label Mar 18, 2024
@AustinAbro321 AustinAbro321 mentioned this issue Mar 22, 2024
Merged
@AustinAbro321 AustinAbro321 mentioned this issue Mar 25, 2024
Merged
5 tasks
Noxsios pushed a commit that referenced this issue Mar 25, 2024
@AustinAbro321 @lucasrod16
chore: move helpers to defenseunicorns/pkg (#2402)
9277bdc 
## Description

Take helpers out of Zarf and moves the package to
https://github.com/defenseunicorns/pkg

Relates to #2252 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Racer159 Racer159

Labels
openssf Issues needing to be completed before donation to OpenSSF tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Zarf
Status: Done
Zarf Project Board
Status: Closed
Milestone
(2024.02.20)
3 participants
@Racer159 @AustinAbro321 @Noxsios