-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context needs to be better passed through to several parts of Zarf so that interrupts can be implemented properly #2594
Labels
tech-debt 💳
Debt that the team has charged and needs to repay
Comments
This was referenced Jun 7, 2024
AustinAbro321
pushed a commit
that referenced
this issue
Jun 7, 2024
…2598) ## Description This changes the behavior so that the second SIGINT signal immediately exits. This is useful if a process is not quitting in context cancel or if it is taking too long to quit. ## Related Issue Relates to #2594 ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow) followed
lucasrod16
pushed a commit
that referenced
this issue
Jun 7, 2024
## Description This change adds contexts to packager functions to enable them to be cancelled. ## Related Issue Relates to #2594 ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow) followed Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
This was referenced Jun 11, 2024
AustinAbro321
pushed a commit
that referenced
this issue
Jul 23, 2024
…2598) ## Description This changes the behavior so that the second SIGINT signal immediately exits. This is useful if a process is not quitting in context cancel or if it is taking too long to quit. ## Related Issue Relates to #2594 ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow) followed Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
AustinAbro321
added a commit
that referenced
this issue
Jul 23, 2024
## Description This change adds contexts to packager functions to enable them to be cancelled. ## Related Issue Relates to #2594 ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow) followed Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com> Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many parts of Zarf do not properly handle context properly. Since #2567 was merged in ctrl-c may not interrupt as a user would expect in several situations.
At least
failed after 0 retries
rather thanpackage creation canceled
The text was updated successfully, but these errors were encountered: