We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As of opening this issue there are ~50 uses of context.TODO throughout the codebase. We should refactor these library functions to accept a context.
context.TODO
https://github.com/search?q=repo%3Adefenseunicorns%2Fzarf+NOT+path%3A*test*+context.TODO&type=code&p=1
While we could create additional GetPodsWithContext functions it might be better to bite the bullet and make this as part of a breaking change.
GetPodsWithContext
The text was updated successfully, but these errors were encountered:
refactor: context usage in k8s code (#2405)
53465d7
## Description refactor context usage in k8s code ## Related Issue Relates to #2365 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Relates to #2592 and #2594
Sorry, something went wrong.
8f891cc
## Description refactor context usage in k8s code ## Related Issue Relates to #2365 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com> Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
schristoff
No branches or pull requests
Describe what should be investigated or refactored
As of opening this issue there are ~50 uses of
context.TODO
throughout the codebase. We should refactor these library functions to accept a context.Links to any relevant code
https://github.com/search?q=repo%3Adefenseunicorns%2Fzarf+NOT+path%3A*test*+context.TODO&type=code&p=1
Additional context
While we could create additional
GetPodsWithContext
functions it might be better to bite the bullet and make this as part of a breaking change.The text was updated successfully, but these errors were encountered: