Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleaner image pulls #2460

Merged
merged 58 commits into from
May 14, 2024
Merged

refactor: cleaner image pulls #2460

merged 58 commits into from
May 14, 2024

Commits on Apr 25, 2024

  1. first stab at re-writing image pulls 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    81dbad6 View commit details
    Browse the repository at this point in the history

  2. mutex and context 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c4c72c1 View commit details
    Browse the repository at this point in the history

  3. simpler annotations 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3372f32 View commit details
    Browse the repository at this point in the history

  4. simplify 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    ad3bc4d View commit details
    Browse the repository at this point in the history

  5. fix 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    24691a4 View commit details
    Browse the repository at this point in the history

  6. block while layers are in progress, might revert 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    df6a74c View commit details
    Browse the repository at this point in the history

  7. fix inifinite blocking 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e99e16c View commit details
    Browse the repository at this point in the history

  8. debug 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    83b0b62 View commit details
    Browse the repository at this point in the history

  9. use channels 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9176ed5 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. try parallel first, fallback to sequential 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e24e275 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4a1bf3a View commit details
    Browse the repository at this point in the history

  3. incremental and retryable saves 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0db1209 View commit details
    Browse the repository at this point in the history

  4. cleanup 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    186f915 View commit details
    Browse the repository at this point in the history

  5. cache cleanup 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8af1bf4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0f1d658 View commit details
    Browse the repository at this point in the history

  7. cleanup 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4f7a323 View commit details
    Browse the repository at this point in the history

  8. one map to rule them all 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    bd56904 View commit details
    Browse the repository at this point in the history

  9. fix cache dir variable 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c4b2c9f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. cleanup 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    8ca8e38 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. go mod tidy 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a4ee1cd View commit details
    Browse the repository at this point in the history

  2. map locks 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ea2a51b View commit details
    Browse the repository at this point in the history

  3. rwlock 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dd21856 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    64ed460 View commit details
    Browse the repository at this point in the history

  5. go mod tidy 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    094563a View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. fix infinite blocking (again) 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cd1a0f4 View commit details
    Browse the repository at this point in the history

  2. changes from review 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4164616 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. a bigger refactor 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e585271 View commit details
    Browse the repository at this point in the history

  2. wacky things 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6e8f458 View commit details
    Browse the repository at this point in the history

  3. wacky things 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c547ca5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e341df7 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Update src/internal/packager/images/pull.go 

    Co-authored-by: Philip Laine <philip.laine@gmail.com>
    @Noxsios @phillebaba
    Noxsios and phillebaba committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a6e9392 View commit details
    Browse the repository at this point in the history

  2. Update src/internal/packager/images/pull.go 

    Co-authored-by: Philip Laine <philip.laine@gmail.com>
    @Noxsios @phillebaba
    Noxsios and phillebaba committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6b931e8 View commit details
    Browse the repository at this point in the history

  3. handle layout not existing error explicitly 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f19fe0e View commit details
    Browse the repository at this point in the history

  4. defer unlocks 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9997ab1 View commit details
    Browse the repository at this point in the history

  5. better use of context 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c10722c View commit details
    Browse the repository at this point in the history

  6. no need to re-declare if not using go-routines 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 6, 2024
    Configuration menu
    Copy the full SHA
    24e6038 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d7b38bd View commit details
    Browse the repository at this point in the history

  8. cleanup 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2c3eb00 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 6, 2024
    Configuration menu
    Copy the full SHA
    141128f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. better use of context 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 7, 2024
    Configuration menu
    Copy the full SHA
    903113c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b12db3f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2af415e View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into improve-image-pull-on-create

    @AustinAbro321
    AustinAbro321 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    47d996a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 8, 2024
    Configuration menu
    Copy the full SHA
    a75f013 View commit details
    Browse the repository at this point in the history

  3. always create clayout 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 8, 2024
    Configuration menu
    Copy the full SHA
    604917d View commit details
    Browse the repository at this point in the history

  4. fix shaLock deadlock 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ffe348d View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cc77661 View commit details
    Browse the repository at this point in the history

  2. changes from review 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fd47445 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b17cb97 View commit details
    Browse the repository at this point in the history

  4. changes from review 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b5d1479 View commit details
    Browse the repository at this point in the history

  5. Update src/internal/packager/images/pull.go 

    Co-authored-by: Lucas Rodriguez <lucas.rodriguez@defenseunicorns.com>
    @Noxsios @lucasrod16
    Noxsios and lucasrod16 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0679740 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4992661 View commit details
    Browse the repository at this point in the history

  7. go mod tidy 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e867b07 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. thanks austin 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 13, 2024
    Configuration menu
    Copy the full SHA
    08096fa View commit details
    Browse the repository at this point in the history

  2. is now working w/ nvidia package 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 13, 2024
    Configuration menu
    Copy the full SHA
    82ae27b View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 14, 2024
    Configuration menu
    Copy the full SHA
    65b6b17 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into improve-image-pull-on-create

    @Noxsios
    Noxsios committed May 14, 2024
    Configuration menu
    Copy the full SHA
    339adc4 View commit details
    Browse the repository at this point in the history

  3. go mod tidy 

    Signed-off-by: razzle <harry@razzle.cloud>
    @Noxsios
    Noxsios committed May 14, 2024
    Configuration menu
    Copy the full SHA
    66cc1f6 View commit details
    Browse the repository at this point in the history