fix: add wait for deployments when updating credentials #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
|
I realize that this change does some duplicate work of #2497 while not introducing new features that require a bit more consensus. It would be for the best to come up with a standard method of using kstatus in the PR as it is also required in other projects like defenseunicorns/lula#229. |
phillebaba
force-pushed
the
fix/cred-update-wait
branch
2 times, most recently
from
4385e11
to
3100505
Compare
phillebaba
force-pushed
the
fix/cred-update-wait
branch
from
3100505
to
4c08d19
Compare
lucasrod16
pushed a commit
to defenseunicorns/pkg
that referenced
this pull request
Jun 7, 2024
## Description This change adds a new Kubernetes package meant for related logic. It also adds functions which allows users to easily wait for resources to be properly reconciled. ## Related Issue Relates to #zarf-dev/zarf#2580 Relates to #defenseunicorns/lula#229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change waits for deployments to update using kstatus when updating credentials. The reason this is necessary is to make sure that all pods have received the updated configuration before the update command returns. Otherwise it would be possible to assume that the configuration has been applied when it has not. Sadly Helm is not able to do this itself as it will not wait for old pods to delete before returning.
Related Issue
Relates to #2566
Checklist before merging