fix: add wait for deployments when updating credentials #2580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change waits for deployments to update using kstatus when updating credentials. The reason this is necessary is to make sure that all pods have received the updated configuration before the update command returns. Otherwise it would be possible to assume that the configuration has been applied when it has not. Sadly Helm is not able to do this itself as it will not wait for old pods to delete before returning.
Related Issue
Relates to #2566
Checklist before merging