[Fix] format: encode query string keys

Fixes #67
defunctzombie · Sep 14, 2023 · c3e0a5d · c3e0a5d
1 parent a6ddc4e
commit c3e0a5d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/test/index.js b/test/index.js
@@ -1164,6 +1164,19 @@ var formatTests = {
     hash: '#frag',
     search: '?abc=the#1?&foo=bar',
     pathname: '/fooA100%mBr'
+  },
+
+  // colons in keys
+  'https://cdpn.io/test?custom%3Aid=12': {
+    href: 'https://cdpn.io/test?custom%3Aid=12',
+    protocol: 'https:',
+    hostname: 'cdpn.io',
+    hash: '',
+    search: '?custom%3Aid=12',
+    pathname: '/test',
+    query: {
+      'custom:id': '12'
+    }
   }
 };
 
@@ -2029,7 +2042,7 @@ relativeTests.forEach(function (relativeTest) {
 });
 
 test('format with querystring', function () {
-  var obj = { protocol: 'https:', host: 'google.com', pathname: 'test', query: { message: ['value1', 'value2'] } };
+  var obj = { protocol: 'https:', host: 'google.com', pathname: 'test', query: { message: ['value1', 'value2'], 'custom:id': 12 } };
 
   var actual = url.format(obj);
   var expected = nodeURL.format(obj);

diff --git a/url.js b/url.js
@@ -436,7 +436,6 @@ Url.prototype.format = function () {
   if (this.query && typeof this.query === 'object' && Object.keys(this.query).length) {
     query = querystring.stringify(this.query, {
       arrayFormat: 'repeat',
-      encodeValuesOnly: true,
       addQueryPrefix: false
     });
   }