Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: Include warning in lockfile about manual editing intention #35

Merged
merged 1 commit into from
Feb 10, 2019

Conversation

rye
Copy link
Contributor

@rye rye commented Feb 10, 2019

Since Cargo keeps putting it back, I don't see why not. It's a comment, after all.

Since Cargo keeps putting it back, I don't see why not.  It's a
comment, after all.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@rye rye requested a review from hawkrives February 10, 2019 17:49
@hawkrives
Copy link
Contributor

Odd, mine wasn't putting that line in.

@hawkrives hawkrives merged commit e2b68c7 into master Feb 10, 2019
@rye
Copy link
Contributor Author

rye commented Feb 10, 2019

@hawkrives when was the last time you rustup update-d? (I have a cron script so I'm a forced adopter of all new nightly changes.)

@rye rye deleted the include-cargo-caveats branch February 10, 2019 19:00
@hawkrives
Copy link
Contributor

I'm running the beta channel, so that could be it

@rye
Copy link
Contributor Author

rye commented Feb 10, 2019

Yes, rust-lang/cargo#6548 is what introduced this behavior. You will get it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants