This repository has been archived by the owner on May 6, 2020. It is now read-only.
fix(slugrunner): use init container to download the slug from objectstorage #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helgi, @zinuzoid and @bacongobbler are potential reviewers of this pull request based on my analysis of |
Current coverage is 87.31% (diff: 91.66%)@@ master #1179 diff @@
==========================================
Files 43 43
Lines 3826 3838 +12
Methods 0 0
Messages 0 0
Branches 665 667 +2
==========================================
+ Hits 3340 3351 +11
Misses 321 321
- Partials 165 166 +1
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the init container to download the slug, thus app container will not have access to the creds for the storage buckets.