Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

feat(deployments): add Deployments documentation #369

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

helgi
Copy link
Contributor

@helgi helgi commented Jul 11, 2016

@helgi helgi added this to the v2.2 milestone Jul 11, 2016
@helgi helgi self-assigned this Jul 11, 2016
@deis-bot
Copy link

@mboersma, @bacongobbler and @slack are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

@@ -39,7 +39,9 @@ RESERVED_NAMES | a comma-separated list of name
SLUGRUNNER_IMAGE_NAME | the image used to run buildpack application slugs (default: "quay.io/deisci/slugrunner:canary")
SLUG_BUILDER_IMAGE_PULL_POLICY | the kubernetes [image pull policy][pull-policy] for slugbuilder (default: "Always")
DOCKER_BUILDER_IMAGE_PULL_POLICY | the kubernetes [image pull policy][pull-policy] for dockerbuilder (default: "Always")
DEIS_DEPLOY_BATCHES | the number of pods to bring up and take down sequentially during a scale (default: all)
DEIS_DEPLOY_BATCHES | the number of pods to bring up and take down sequentially during a scale (default: number of available nodes)
DEIS_KUBERNETES_DEPLOYMENTS | if [Deployments][] is used to handle an application deploy instead off [ReplicationControllers][] (default: off)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value to enable it would be useful here: on, true, yes, plz, yesplz, omgwtfbbqyes

Should also state that this defines the default platform behavior

Setting | Description
----------------------------------------------- | ---------------------------------
DEIS_DEPLOY_BATCHES | the number of pods to bring up and take down sequentially during a scale (default: number of available nodes)
DEIS_KUBERNETES_DEPLOYMENTS | if enabled [Deployments][] is used to handle an application deploy instead off [ReplicationControllers][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "off" -> "of"

@mboersma mboersma added the LGTM1 label Jul 13, 2016
@helgi helgi merged commit 1dae122 into deis:master Jul 14, 2016
@helgi helgi deleted the deployments branch July 14, 2016 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants