This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 180
feat(deployments): add Deployments documentation #369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mboersma, @bacongobbler and @slack are potential reviewers of this pull request based on my analysis of |
3 tasks
@@ -39,7 +39,9 @@ RESERVED_NAMES | a comma-separated list of name | |||
SLUGRUNNER_IMAGE_NAME | the image used to run buildpack application slugs (default: "quay.io/deisci/slugrunner:canary") | |||
SLUG_BUILDER_IMAGE_PULL_POLICY | the kubernetes [image pull policy][pull-policy] for slugbuilder (default: "Always") | |||
DOCKER_BUILDER_IMAGE_PULL_POLICY | the kubernetes [image pull policy][pull-policy] for dockerbuilder (default: "Always") | |||
DEIS_DEPLOY_BATCHES | the number of pods to bring up and take down sequentially during a scale (default: all) | |||
DEIS_DEPLOY_BATCHES | the number of pods to bring up and take down sequentially during a scale (default: number of available nodes) | |||
DEIS_KUBERNETES_DEPLOYMENTS | if [Deployments][] is used to handle an application deploy instead off [ReplicationControllers][] (default: off) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value to enable it would be useful here: on, true, yes, plz, yesplz, omgwtfbbqyes
Should also state that this defines the default platform behavior
Setting | Description | ||
----------------------------------------------- | --------------------------------- | ||
DEIS_DEPLOY_BATCHES | the number of pods to bring up and take down sequentially during a scale (default: number of available nodes) | ||
DEIS_KUBERNETES_DEPLOYMENTS | if enabled [Deployments][] is used to handle an application deploy instead off [ReplicationControllers][] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "off" -> "of"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires deis/controller#854