Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): replace deprecated ingress annotation #185

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

vdice
Copy link
Member

@vdice vdice commented Nov 15, 2023

Noticed a deprecation warning around the ingress annotation when running the shim via k3s. (Warning: annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead)

Updated applicable manifests per https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mossaka Mossaka merged commit 142467d into deislabs:main Nov 16, 2023
20 checks passed
@vdice vdice deleted the fix/deprecated-ingress-annotation branch November 16, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants