ci: pin cross and rust versions #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
|
Confirmed that an older cross image |
|
It looks like the |
|
cross-rs/cross#1418 this PR adds PIE back. |
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
devigned
approved these changes
Jan 19, 2024
Thanks! Just to clarify, locking in the version did not fix the PIE compilation issue. The fix was on upstream cross repo to enable PIE compilation in musl library. |
Mossaka
added a commit
to radu-matei/containerd-wasm-shims
that referenced
this pull request
Jan 23, 2024
* ci: pin cross and rust versions * fixed the commit rev * pin rust version to 1.75 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the Rust toolchain and the Makefile to ensure specific versions are used and to include new components and targets. The most important changes include updating the
rust-toolchain.tomlfile to use Rust version 1.75.0 and updating theinstall-crosstarget in theMakefileto specify a specific commit when installingcross.