-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new shim for Wasm Workers Server #88
Conversation
@microsoft-github-policy-service agree company="VMware, Inc" |
I'm really looking forward to this. |
@Angelmmiguel thanks for your contribution! I am really excited for this. I will be travelling to attend KubeCon EU next week and will be back on April 23rd. Will review your PR by then. |
That’s great @Mossaka! I’ll be in KubeCon too 😄 |
Will try to run this locally on my machine today and review the PR! Thanks for waiting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM! I will need to run commands locally to test everything still works, and run CI to make sures it still works. Awesome work @Angelmmiguel !
I will ask @devigned to take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, @Angelmmiguel! I have a couple questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried make up
and make test
locally and it looks like all the images were able to built correctly and loaded correctly to k3d, but I was not able to get the response from wws shim, unlike the other shims.
I believe the issue was that the lable was not correctly set up
The pod had an error message in its events saying
Warning FailedScheduling 16s default-scheduler 0/2 nodes are available: 2 node(s) didn't match Pod's node affinity/selector. preemption: 0/2 nodes are available: 2 Preemption is not helpful for scheduling.
whooohoooooo |
@Mossaka @devigned thank you for the thorough review! I already submitted some changes regarding using the 3000 port and the missing Makefile tasks and deps. The pending changes are:
I'm having some issues regarding my environment (Docker Desktop on MacOS M1) when building the different shims. I get an error when compiling the Thank you! |
If you wanna chat with @rumpl about Docker, he knows ALL :-) |
That would be really great! I think this case is a mix of Docker and Rust + Cross. It should a simple configuration thing. If you have some time @rumpl, it would be great to check it :) Thank you for the introduction @squillace! |
@@ -1,50 +1,59 @@ | |||
IMAGE_NAME ?= k3swithshims | |||
CLUSTER_NAME ?= k3s-default | |||
PLATFORM ?= linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this configuration option useful when working with MacOS M1. Now, I can configure the image to linux/arm64
when working with k3d. However, I can move this to a separate PR if it's more convenient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks for your contribution @Angelmmiguel
Hello 👋
My name is Angel and I'm part of the Wasm Labs team. I'm a maintainer of the Wasm Workers Server project, an OSS project to develop and run serverless applications on top of WebAssembly.
I created a new shim that adds support for this kind of workloads. It allows you to run Wasm Workers Server apps the same way you can now with Spin and Slight. Here you have several example apps.
The code is pretty similar to the
slight
andspin
shims. It was an easy integration thanks to all the features provided byrunwasi
and the previous work on those shims. Thank you for all your effort on this! 😄I also updated the documentation and scripts to reflect the new shim.
Summary
containerd-shim-wws-v1
shimPlease, feel free to suggest any change or requirement on the PR.
Thank you!