app.test.tsx changes #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
force-pushed
the
app.test.tsx
branch
4 times, most recently
from
2d22e8e to
cb923f5
Compare
dej611
approved these changes
Sep 20, 2024
mbondyra
force-pushed
the
app.test.tsx
branch
from
cb923f5 to
c2ab4e0
Compare
dej611
reviewed
Sep 24, 2024
| function makeDefaultProps(): jest.Mocked<LensAppProps> { | ||
| return { | ||
| editorFrame: createMockFrame(), | ||
| let props: jest.Mocked<LensAppProps>; |
There was a problem hiding this comment.
One question here.
What's the benefit of having a shared variable and reset it on every test with a beforeEach vs generating all the mocks explicitly every time?
It is just code readability (not calling it every time) or there's more?
There was a problem hiding this comment.
There's way less code to read (like calling makeDefaultProps function and then modifying the properties we want and then pass it to the renderApp) with this pattern so I think it's just nicer :)
dej611
reviewed
Sep 24, 2024
|
|
||
| const sessionIdSubject = new Subject<string>(); | ||
| const getLensDocumentMock = (someProps?: Partial<LensDocument>) => ({ |
There was a problem hiding this comment.
In the original code there's a cloneDeep function that wraps this to enable document manipulation within tests without worry about influencing other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers