New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form initial implementation #1

Open

dejanpreradovic wants to merge 4 commits into main from milo-form

Owner

dejanpreradovic commented Aug 29, 2023

Milo form initial implementation based on discussion:
https://github.com/orgs/adobecom/discussions/937


          Form initial implementation

54114a6

aem-code-sync bot commented Aug 29, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-run PSI Checks

dejanpreradovic commented

View reviewed changes

blocks/form/checkbox-checked.svg

Owner Author

dejanpreradovic Aug 29, 2023

taken from helix-website project

dejanpreradovic commented

View reviewed changes

blocks/form/checkbox.svg

Owner Author

dejanpreradovic Aug 29, 2023

taken from helix-website project

dejanpreradovic commented

View reviewed changes

blocks/form/form.css

Owner Author

dejanpreradovic Aug 29, 2023

taken from helix-website project. Added few additional css rules on top of it.

dejanpreradovic commented

View reviewed changes

blocks/form/form.js

Owner Author

dejanpreradovic Aug 29, 2023 •

edited

Loading

taken from helix-website project. Changes that are made in this file are mentioned in comment that Ben Zahler mentioned in this discussion comment:
https://github.com/orgs/adobecom/discussions/937#discussioncomment-6852206

dejanpreradovic commented

View reviewed changes

styles/styles.css

Owner Author

dejanpreradovic Aug 29, 2023

styles from helix-website project required for their form implementation.

dejanpreradovic commented

View reviewed changes

tools/utils/helpers.js

Owner Author

dejanpreradovic Aug 29, 2023

helper methods taken from helix-website project needed for form intitialize animation.

dejanpreradovic commented

View reviewed changes

tools/utils/tag.js

Owner Author

dejanpreradovic Aug 29, 2023

helix-website helpers.js dependency


          changed form action for testing purpose

bc143f4

aem-code-sync bot commented Aug 30, 2023

Page	Scores	Audits	Google
/drafts/dejan/form-example
/drafts/dejan/hello

dejanpreradovic added 2 commits

September 1, 2023 12:05


          fixed es lint issues

4c84637


          different approach for submit url

1ee1551

aem-code-sync bot commented Sep 1, 2023

Page	Scores	Audits	Google
/drafts/dejan/hello
/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet