Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary files #9

Merged
merged 7 commits into from
Feb 24, 2022
Merged

Remove unnecessary files #9

merged 7 commits into from
Feb 24, 2022

Conversation

iAtog
Copy link
Contributor

@iAtog iAtog commented Feb 22, 2022

Several files were removed, such as IntelliJ IDEA and maven files, and I added some files to the .gitignore so that they are not removed from your project and will not be visible in the repository.

I also added eclipse files to ignore for future contributors and my future contribution.

@dejvokep
Copy link
Owner

dejvokep commented Feb 22, 2022

Hey, awesome contribution; forgot to add them to the .gitignore but it makes the repository cleaner, for sure.

Only one question: was there any reason for deleting the LICENSE-header.txt file? Could you please bring it back, if possible? Thanks and have an awesome day.
~ dejvokep

@dejvokep dejvokep self-requested a review February 22, 2022 13:27
@iAtog
Copy link
Contributor Author

iAtog commented Feb 23, 2022

Hey, awesome contribution; forgot to add them to the .gitignore but it makes the repository cleaner, for sure.

Only one question: was there any reason for deleting the LICENSE-header.txt file? Could you please bring it back, if possible? Thanks and have an awesome day. ~ dejvokep

As I could see it is just the license, I added it to the .gitignore so it would not appear in the repository, I guess you use it to place it in your files, but if it is for personal use it is ok to ignore it, anyway it would not be removed from your files, you can also specify it if you want it in the README.md, but if you want it in the repository you can confirm me again and I will gladly do it.

@dejvokep
Copy link
Owner

Thanks for the response! Yes, you are right, I will do my best to create some contributing guidelines as soon as possible.

Regarding the file: it is used by the Maven licensing plugin, so it would be awesome if you brought it back.

I will then merge the PR. Thank you :)

@iAtog
Copy link
Contributor Author

iAtog commented Feb 23, 2022

It's ready, I've added the file, sorry for the delay.

@dejvokep
Copy link
Owner

No problem, thanks again for your contribution. Have an amazing day :)

@dejvokep dejvokep merged commit a57b03f into dejvokep:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants