Updated framework so it doesn't have to be modified to be used #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the underlying library. Updated readme with browser information and new documentation
|
Sorry for the delay. I think this is a great addition, but I think you could make it backward compatible at the moment. Due to a recent change in the spec, synchronously importing scripts has the advantage that if the tests are modified, the service worker is automatically updated but since every test run happens (or should happen for this library to work) in a cleared state, this does not really matter. Anyway, I think automatic deregistration of the service worker would be another great addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve updated the framework so that