Update aztec_code_generator.py #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed part when leaving binary mode to any other mode. Issue for the number of bytes when superior to 31 corrected.
dlenski
added a commit
to dlenski/aztec_code_generator
that referenced
this pull request
Oct 19, 2020
Assuming that new sequences after delimitry#5 are indeed optimal.
dlenski
added a commit
to dlenski/aztec_code_generator
that referenced
this pull request
Oct 19, 2020
|
The tests were broken by this change. I fixed them in my fork (which also adds Python packaging), in dlenski@f2bcd2d … based on the assumption that the new sequences resulting from this PR are indeed the correct ones. |
|
@dlenski Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed part when leaving binary mode to any other mode.
Issue for the number of bytes when superior to 31 corrected.