Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for invoke_report_execution.py to get the colum names in the right order (issue #234) #240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaOb74
Copy link

@MaOb74 MaOb74 commented Feb 7, 2023

invoke_report_execution.py: fix for #234

  • to get the column names for a report in the right order, you have to get that from: https://<ome_ip>/api/ReportService/ReportDefs(<report_id>)/ReportResults

Copy link

@vincent-legoll vincent-legoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just passing by...

Apart from the proposed cleanup, the remaining changes LGTM, but I did not check too deeply (URL subdirectory, json data map keys...)


column_names = [x['Name'] for x in column_info_arr]
# get the column names
report_results_url = self.base_url + 'ReportService/ReportDefs(%s)/ReportResults' % self.report_id

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
report_results_url = self.base_url + 'ReportService/ReportDefs(%s)/ReportResults' % self.report_id
report_results_url = report_details_url + '/ReportResults'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants