Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ubi dependencies #74

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Update ubi dependencies #74

merged 2 commits into from
Jun 11, 2024

Conversation

Sahiba-Gupta
Copy link
Contributor

@Sahiba-Gupta Sahiba-Gupta commented Jun 6, 2024 •
edited
Loading

This PR updates the UBI micro dependencies.

| GitHub Issue # |
https://github.com/dell/csm/issues/1221|

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

For now I have tested this change locally ( by running make docker ) and verified that both images have been created and rpm is added.

AkshaySainiDell
AkshaySainiDell approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sahiba-Gupta
Copy link
Contributor Author

run e2e

donatwork
donatwork reviewed Jun 7, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@rodrigobassil rodrigobassil self-requested a review June 10, 2024 20:20
@Sahiba-Gupta Sahiba-Gupta force-pushed the Update_ubi_dependencies branch from 9ee1d1e to ef948b0 Compare June 10, 2024 23:27
@Sahiba-Gupta
KRV-24639: Add RPM
a39554d 
Signed-off-by: Sahiba_G <sahiba.gupta1@dell.com>
@Sahiba-Gupta
remove localhost
5f2cdd0 
Signed-off-by: Sahiba_G <sahiba.gupta1@dell.com>
@Sahiba-Gupta Sahiba-Gupta force-pushed the Update_ubi_dependencies branch from ef948b0 to 5f2cdd0 Compare June 11, 2024 02:07
@Sahiba-Gupta Sahiba-Gupta merged commit a9d2a1b into main Jun 11, 2024
4 checks passed
@Sahiba-Gupta Sahiba-Gupta deleted the Update_ubi_dependencies branch June 11, 2024 02:11
tdawe pushed a commit that referenced this pull request Aug 12, 2024
@Sahiba-Gupta
Merge pull request #74 from dell/Update_ubi_dependencies
fa4f846 
Update ubi dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@rodrigobassil rodrigobassil rodrigobassil approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sahiba-Gupta @donatwork @AkshaySainiDell @rodrigobassil