Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gosec fix #78

Merged
merged 0 commits into from
Jul 19, 2024
Merged

Gosec fix #78

merged 0 commits into from
Jul 19, 2024

Conversation

adarsh-dell
Copy link
Contributor

@adarsh-dell adarsh-dell commented Jul 19, 2024 •
edited
Loading

Description

Gosec fix

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran gosec tool, it reported 0 issues.

Before:
image

After:
image

  • Ran basic scaling cert-csi suite
image image image

suryagupta4
suryagupta4 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@suryagupta4 suryagupta4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adarsh-dell adarsh-dell merged this pull request into main Jul 19, 2024
4 checks passed
@shanmydell shanmydell deleted the gosecFilePermissionFix branch July 19, 2024 07:03
tdawe pushed a commit that referenced this pull request Aug 12, 2024
@adarsh-dell
Merge pull request #78 from dell/gosecFilePermissionFix
b0acb1f 
Gosec fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilltaran gilltaran gilltaran approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@JacobGros JacobGros Awaiting requested review from JacobGros

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@khareRajshree khareRajshree Awaiting requested review from khareRajshree

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@panigs7 panigs7 Awaiting requested review from panigs7

@tssushma tssushma Awaiting requested review from tssushma

@shanmydell shanmydell Awaiting requested review from shanmydell

@alikdell alikdell Awaiting requested review from alikdell

@atye atye Awaiting requested review from atye

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@xuluna xuluna Awaiting requested review from xuluna

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adarsh-dell @gilltaran @suryagupta4 @rishabhatdell