Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering get topology count for specific sc key #98

Open
wants to merge 121 commits into
base: main
Choose a base branch
from

Conversation

sakshi-garg1
Copy link
Contributor

Description

Customer was facing issue with running cert-csi functional test when they had multiple drivers installed. The issue with the test was that it was getting all the topologies for all drivers.

To resolve this, we will only get topology keys based on the ones listed in the storage class.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1504

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@jooseppi-luna
Copy link
Contributor

closing because this is not ready for merge

@aqu-dell aqu-dell reopened this Jan 24, 2025
aqu-dell and others added 15 commits January 24, 2025 16:54
* initial commit

* attempt to populate pvc object bound state

* code cleanup

* added clearer comments

* set pvc status to bound and manually set pvc name

* fixed mock for pvc, added bound status

* changed clientset to use rest

* added more lines of coverage

* cleaned up comments
Signed-off-by: meghana_gm <meghana.gm@dell.com>
Signed-off-by: meghana_gm <meghana.gm@dell.com>
Signed-off-by: meghana_gm <meghana.gm@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.