Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/multistage go build #39

Merged
merged 10 commits into from
Jan 22, 2024
Merged

Feature/multistage go build #39

merged 10 commits into from
Jan 22, 2024

Conversation

adarsh-dell
Copy link
Contributor

Description

Multistage go build for docker image building

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Verified make all command, that will be help page for the user like other CSM repo and product.
    image

  • Build the docker image and verified BASE_IMAGE and Builder.
    image
    image

@adarsh-dell adarsh-dell marked this pull request as ready for review January 22, 2024 04:38
suryagupta4
suryagupta4 previously approved these changes Jan 22, 2024
View reviewed changes
@adarsh-dell adarsh-dell merged commit 9643f56 into main Jan 22, 2024
3 of 4 checks passed
@anandrajak1 anandrajak1 deleted the feature/multistageGoBuild branch October 17, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@harshitap26 harshitap26 Awaiting requested review from harshitap26 harshitap26 is a code owner

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1 niranjan-n1 is a code owner

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri satyakonduri is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@kenivi1 kenivi1 Awaiting requested review from kenivi1 kenivi1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adarsh-dell @AkshaySainiDell @suryagupta4 @rishabhatdell