Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ubi dependencies #55

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Update ubi dependencies #55

merged 5 commits into from
Jun 11, 2024

Conversation

Sahiba-Gupta
Copy link
Contributor

@Sahiba-Gupta Sahiba-Gupta commented Jun 6, 2024 •
edited
Loading

This PR updates the UBI micro dependencies.

GitHub Issue #
dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

For now I have tested this change locally ( by running make docker ) and verified that both images have been created and rpm is added.

@gallacher
Copy link
Contributor

@Sahiba-Gupta - please outline all the testing that was performed to validate this change did not create any regressions. Thank you!

@Sahiba-Gupta
Copy link
Contributor Author

run e2e test

anandrajak1
anandrajak1 previously approved these changes Jun 10, 2024
View reviewed changes
rodrigobassil
rodrigobassil previously approved these changes Jun 10, 2024
View reviewed changes
@Sahiba-Gupta Sahiba-Gupta force-pushed the Update_ubi_dependencies branch from 811c3f2 to 795e83d Compare June 11, 2024 13:18
@Sahiba-Gupta Sahiba-Gupta merged commit b3caac2 into main Jun 11, 2024
4 checks passed
@Sahiba-Gupta Sahiba-Gupta deleted the Update_ubi_dependencies branch June 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrajak1 anandrajak1 anandrajak1 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@rodrigobassil rodrigobassil rodrigobassil approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@harshitap26 harshitap26 Awaiting requested review from harshitap26 harshitap26 is a code owner

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1 niranjan-n1 is a code owner

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri satyakonduri is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@kenivi1 kenivi1 Awaiting requested review from kenivi1 kenivi1 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sahiba-Gupta @gallacher @anandrajak1 @AkshaySainiDell @rodrigobassil