fix comments and error messages in values and nodeProbe

dell · Feb 3, 2023 · ae9719b · ae9719b
1 parent f18f98c
commit ae9719b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/helm/csi-vxflexos/values.yaml b/helm/csi-vxflexos/values.yaml
@@ -215,8 +215,8 @@ node:
   approveSDC: 
     # enabled: Enable/Disable SDC approval
     #Allowed values:
-    #  true: enable approval
-    #  false: disable approval
+    #  true: Driver will attempt to approve restricted SDC by GUID during setup
+    #  false: Driver will not attempt to approve restricted SDC by GUID during setup
     # Default value: false
     enabled: false
 

diff --git a/service/node.go b/service/node.go
@@ -434,7 +434,7 @@ func (s *service) approveSDC(opts Opts) error {
 		system := s.systems[systemID]
 
 		if system == nil {
-			return nil
+			continue
 		}
 
 		//fetch SDC details
@@ -456,8 +456,7 @@ func (s *service) approveSDC(opts Opts) error {
 			}
 		} else {
 			if !sdc.Sdc.SdcApproved {
-				return status.Errorf(codes.FailedPrecondition,
-					"Array RestrictedSdcMode is %s, driver only supports GUID RestrictedSdcMode cannot approve SDC %s",
+				return status.Errorf(codes.FailedPrecondition, "Array RestrictedSdcMode is %s, driver only supports GUID RestrictedSdcMode cannot approve SDC %s",
 					system.System.RestrictedSdcMode, sdc.Sdc.SdcGUID)
 			}
 			Log.Warnf("Array RestrictedSdcMode is %s, driver only supports GUID RestrictedSdcMode If SDC becomes restricted again, driver will not be able to approve",