Address PR comments

dell · Sep 30, 2024 · d426453 · d426453
1 parent 3f7ef50
commit d426453
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/service/controller.go b/service/controller.go
@@ -1288,6 +1288,7 @@ func (s *service) ControllerPublishVolume(
 		var ipAddresses []string
 
 		ipAddresses, err = s.findNetworkInterfaceIPs()
+		Log.Printf("ControllerPublish - No network interfaces found, trying to get SDC IPs")
 		if err != nil || len(ipAddresses) == 0 {
 
 			// get SDC IPs if Network Interface IPs not found
@@ -1298,7 +1299,7 @@ func (s *service) ControllerPublishVolume(
 				return nil, status.Errorf(codes.NotFound, "%s", "received empty sdcIPs")
 			}
 		}
-		Log.Printf("ControllerPublish - Network Interface IPs for NFS: %v", ipAddresses)
+		Log.Printf("ControllerPublish - ipAddresses %v", ipAddresses)
 
 		externalAccess := s.opts.ExternalAccess
 		publishContext["host"] = ipAddresses[0]

diff --git a/service/node.go b/service/node.go
@@ -942,7 +942,6 @@ func (s *service) NodeExpandVolume(ctx context.Context, req *csi.NodeExpandVolum
 	err = s.nodeProbe(ctx)
 	if err != nil {
 		Log.Error("nodeProbe failed with error :" + err.Error())
-		// return nil, err
 	}
 
 	volumePath := req.GetVolumePath()

diff --git a/service/service.go b/service/service.go
@@ -263,7 +263,11 @@ func (s *service) logCsiNodeTopologyKeys() error {
 		K8sClientset = k8sutils.Clientset
 	}
 
-	csiNodes, _ := K8sClientset.StorageV1().CSINodes().List(context.TODO(), metav1.ListOptions{})
+	csiNodes, err := K8sClientset.StorageV1().CSINodes().List(context.TODO(), metav1.ListOptions{})
+	if err != nil {
+		Log.WithError(err).Error("unable to get node list")
+		return err
+	}
 	node, err := s.NodeGetInfo(context.Background(), nil)
 	if node != nil {
 		Log.WithField("node info", node.NodeId).Info("NodeInfo ID")