Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renameSDC operation updated for multiarray cluster support #163

Merged
merged 1 commit into from
Feb 16, 2023
Merged

renameSDC operation updated for multiarray cluster support #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/csi-vxflexos/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ node:
# false: disable renaming
# Default value: "false"
enabled: false
# "prefix" defines a string for the new name of the SDC.
# "prefix" defines a string for prefix of the SDC name.
# "prefix" + "worker_node_hostname" should not exceed 31 chars.
# Default value: none
# Examples: "rhel-sdc", "sdc-test"
Expand Down
3 changes: 3 additions & 0 deletions service/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,9 @@ func (s *service) renameSDC(opts Opts) error {

// fetch SDC details
for _, systemID := range connectedSystemID {
if s.systems[systemID] == nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you log any message in this case?

continue
}
sdc, err := s.systems[systemID].FindSdc("SdcGUID", opts.SdcGUID)
if err != nil {
return status.Errorf(codes.FailedPrecondition, "%s", err)
Expand Down