Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out the sample to avoid error when not needed #261

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Comment out the sample to avoid error when not needed #261

merged 2 commits into from
Nov 9, 2023

Conversation

coulof
Copy link
Collaborator

@coulof coulof commented Nov 7, 2023

Description

Commenting out the 2nd array per requirement here : dell/csm#1030

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1030

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Not tested

AronAtDell
AronAtDell reviewed Nov 7, 2023
View reviewed changes
samples/secret.yaml Outdated Show resolved Hide resolved
AronAtDell
AronAtDell previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@AronAtDell AronAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment. Looks good. Thanks!

adarsh-dell
adarsh-dell previously approved these changes Nov 7, 2023
View reviewed changes
AkshaySainiDell
AkshaySainiDell previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

AkshaySainiDell
AkshaySainiDell approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coulof coulof merged commit 8317370 into main Nov 9, 2023
@AronAtDell AronAtDell deleted the update-sample-config branch October 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AronAtDell AronAtDell AronAtDell left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@JacobGros JacobGros Awaiting requested review from JacobGros

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@khareRajshree khareRajshree Awaiting requested review from khareRajshree

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell

@mjsdell mjsdell Awaiting requested review from mjsdell

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@VamsiSiddu-7 VamsiSiddu-7 Awaiting requested review from VamsiSiddu-7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coulof @AronAtDell @AkshaySainiDell @adarsh-dell