Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get csm-base-image instead of building it. #402

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

anathoodell
Copy link
Contributor

@anathoodell anathoodell commented Jan 27, 2025

Description

Use the common CSM base image for image builds. The benefit is that it will now be possible to build images on non RHEL VMs and as a non root user.

GitHub Issues

GitHub Issue #
dell/csm#1691

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Built Images
  • Run cert-csi on image

@anathoodell
Copy link
Contributor Author

anathoodell commented Jan 28, 2025

cert-csi test results:

for image built from usr/anathoodell/csmbaseimage
Collecting metrics
Collecting metrics
Generating plots
report-test-run-d84ff693:
Name: test-run-d84ff693

StorageClass: powerflex-multiaz
Minimum and Maximum EntityOverTime charts:

/root/.cert-csi/reports/test-run-d84ff693/PodsCreatingOverTime.png

/root/.cert-csi/reports/test-run-d84ff693/PodsReadyOverTime.png

/root/.cert-csi/reports/test-run-d84ff693/PodsTerminatingOverTime.png

/root/.cert-csi/reports/test-run-d84ff693/PvcsCreatingOverTime.png

/root/.cert-csi/reports/test-run-d84ff693/PvcsBoundOverTime.png

Tests:
--------------------------------------------------------------
1. TestCase: ProvisioningSuite
            Started:   2025-01-28 10:17:43.571006987 -0500 -0500
            Ended:     2025-01-28 10:18:13.623950758 -0500 -0500
            Result:    SUCCESS

            Stage metrics:
                    PVCAttachment:
                        Avg: 606.959863ms
                        Min: 205.946952ms
                        Max: 1.009231494s
                        Histogram:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCAttachment.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCAttachment_boxplot.png
                    PVCBind:
                        Avg: 955.782768ms
                        Min: 901.368947ms
                        Max: 988.018225ms
                        Histogram:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCBind.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCBind_boxplot.png
                    PVCCreation:
                        Avg: 1.726333745s
                        Min: 1.313124525s
                        Max: 2.135399417s
                        Histogram:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCCreation.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCCreation_boxplot.png
                    PVCDeletion:
                        Avg: 921.636669ms
                        Min: 910.021644ms
                        Max: 931.761502ms
                        Histogram:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCDeletion.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCDeletion_boxplot.png
                    PVCUnattachment:
                        Avg: 166.519627ms
                        Min: 157.824385ms
                        Max: 183.762986ms
                        Histogram:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCUnattachment.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PVCUnattachment_boxplot.png
                    PodCreation:
                        Avg: 12.037639956s
                        Min: 12.037639956s
                        Max: 12.037639956s
                        Histogram:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PodCreation.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PodCreation_boxplot.png
                    PodDeletion:
                        Avg: 1.040076892s
                        Min: 1.040076892s
                        Max: 1.040076892s
                        Histogram:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PodDeletion.png
                        BoxPlot:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/PodDeletion_boxplot.png
                        EntityNumberOverTime:
        /root/.cert-csi/reports/test-run-d84ff693/ProvisioningSuite3/EntityNumberOverTime.png

@gallacher
Copy link
Contributor

Please address the yaml lint warning

docker.mk Outdated Show resolved Hide resolved
@anathoodell anathoodell requested a review from donatwork January 28, 2025 15:54
@anathoodell anathoodell merged commit 963bbac into main Jan 28, 2025
6 checks passed
@anathoodell anathoodell deleted the usr/anathoodell/csmbaseimage branch January 28, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants