Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to driver node pod for Resiliency protection #93

Merged
merged 1 commit into from
May 19, 2022
Merged

Add label to driver node pod for Resiliency protection #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions helm/csi-vxflexos/templates/node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ spec:
selector:
matchLabels:
app: {{ .Release.Name }}-node
{{- if eq .Values.podmon.enabled true }}
driver.dellemc.com: dell-storage
{{- end }}
template:
metadata:
labels:
Expand Down
4 changes: 3 additions & 1 deletion helm/csi-vxflexos/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,21 +196,23 @@ vgsnapshotter:
# Enable this feature only after contact support for additional information
podmon:
enabled: false
image: dellemc/podmon:v1.1.0
image: dellemc/podmon:v1.2.0
#controller:
# args:
# - "--csisock=unix:/var/run/csi/csi.sock"
# - "--labelvalue=csi-vxflexos"
# - "--mode=controller"
# - "--skipArrayConnectionValidation=false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "--arrayConnectivityPollRate=5" and "--arrayConnectivityConnectionLossThreshold=3" to align with what we have in the documentation?

Copy link
Contributor Author

@alikdell alikdell May 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are optionally can be added into configmap, enable user to dynamically update, reason they aren't in default values.yaml.

# - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml"
# - "--driverPodLabelValue=dell-storage"
#node:
# args:
# - "--csisock=unix:/var/lib/kubelet/plugins/vxflexos.emc.dell.com/csi_sock"
# - "--labelvalue=csi-vxflexos"
# - "--mode=node"
# - "--leaderelection=false"
# - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml"
# - "--driverPodLabelValue=dell-storage"

# CSM module attributes
# authorization: enable csm-authorization for RBAC
Expand Down