updates for gosec (#254)

dell · Dec 4, 2023 · e888ff1 · e888ff1
1 parent f6b8c86
commit e888ff1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/csireverseproxy/main.go b/csireverseproxy/main.go
@@ -160,8 +160,9 @@ func (s *Server) Start() {
 		port := utils.GetListenAddress(s.Port)
 		handler := s.GetRevProxy().GetRouter()
 		server := http.Server{
-			Addr:    port,
-			Handler: handler,
+			Addr:              port,
+			Handler:           handler,
+			ReadHeaderTimeout: 5 * time.Second,
 		}
 		go func() {
 			defer s.WaitGroup.Done()

diff --git a/csireverseproxy/pkg/k8smock/k8smock.go b/csireverseproxy/pkg/k8smock/k8smock.go
@@ -18,6 +18,7 @@ import (
 	"context"
 	"fmt"
 	"os"
+	"path/filepath"
 	"strconv"
 	"time"
 
@@ -107,6 +108,7 @@ func (mockUtils *MockUtils) GetCertFileFromSecretName(secretName string) (string
 }
 
 func (mockUtils *MockUtils) createFile(fileName string, data []byte) error {
+	fileName = filepath.Clean(fileName)
 	file, err := os.Create(fileName)
 	if err != nil {
 		return err

diff --git a/csireverseproxy/pkg/k8sutils/k8sutils.go b/csireverseproxy/pkg/k8sutils/k8sutils.go
@@ -209,6 +209,7 @@ func (utils *K8sUtils) GetCredentialsFromSecret(secret *corev1.Secret) (*common.
 }
 
 func (utils *K8sUtils) createFile(fileName string, data []byte) error {
+	fileName = filepath.Clean(fileName)
 	file, err := os.Create(fileName)
 	if err != nil {
 		return err