Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent variable names #152

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Consistent variable names #152

merged 1 commit into from
Dec 27, 2022

Conversation

delldubey
Copy link
Contributor

@delldubey delldubey commented Dec 20, 2022 •
edited
Loading

Description

Makes variable names consistent for AutoRDM/vSphere across the driver.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#584
dell/csm#592

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

  • Cluster test

@delldubey delldubey force-pushed the feature-584-nameConsistency branch 2 times, most recently from a446f17 to 6850c94 Compare December 27, 2022 09:04
nidtara
nidtara previously approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@delldubey delldubey force-pushed the feature-584-nameConsistency branch from 6850c94 to e8f35c6 Compare December 27, 2022 09:13
@delldubey delldubey requested a review from nidtara December 27, 2022 09:14
tssushma
tssushma approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

boyamurthy
boyamurthy approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@delldubey delldubey merged commit 9f8cee7 into main Dec 27, 2022
@delldubey delldubey deleted the feature-584-nameConsistency branch July 18, 2023 09:17
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@delldubey @Sahiba-Gupta
Makes variable names consistent (#152)
9daa4a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@nidtara nidtara nidtara approved these changes

@tssushma tssushma tssushma approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

@shampavman shampavman Awaiting requested review from shampavman

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delldubey @boyamurthy @nidtara @tssushma