Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the modules to v2 and csi spec to 1.5 #21

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Updates the modules to v2 and csi spec to 1.5 #21

merged 1 commit into from
Oct 22, 2021

Conversation

elahinuman
Copy link
Contributor

Description

This PR:

  • Updates the CSI Spec to 1.5.
  • Adds /v2 suffix to the module names.
  • Updates the ubim image to 8.4-210.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#77

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Tested it by creating the builds and running the unit tests.

@delldubey delldubey self-requested a review October 22, 2021 10:02
shanmydell
shanmydell previously approved these changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

boyamurthy
boyamurthy previously approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@elahinuman elahinuman dismissed stale reviews from boyamurthy and shanmydell via abec005 October 22, 2021 11:24
boyamurthy
boyamurthy approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

delldubey
delldubey approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elahinuman elahinuman merged commit c88c37c into main Oct 22, 2021
@shanmydell shanmydell deleted the features/latest branch October 22, 2021 11:32
miyamotoh pushed a commit to miyamotoh/csi-powermax that referenced this pull request Oct 28, 2021
@elahinuman
Updates the modules to v2 and csi spec to 1.5 (dell#21)
842e0ea
@shanmydell shanmydell mentioned this pull request Nov 16, 2021
Closed
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@elahinuman @Sahiba-Gupta
Updates the modules to v2 and csi spec to 1.5 (#21)
1111052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@delldubey delldubey delldubey approved these changes

@mjsdell mjsdell Awaiting requested review from mjsdell

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elahinuman @shanmydell @boyamurthy @delldubey @utkarsh2296