Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docker command is failing #248

Merged
merged 3 commits into from
Nov 27, 2023
Merged

make docker command is failing #248

merged 3 commits into from
Nov 27, 2023

Conversation

shanmydell
Copy link
Collaborator

@shanmydell shanmydell commented Nov 22, 2023

Description

Fixing the make docker command failure

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1051

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Executed make docker command and it is running successfully

Dockerfile Show resolved Hide resolved
Copy link
Contributor

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanmydell shanmydell merged commit bcbb6ab into main Nov 27, 2023
3 of 4 checks passed
@shanmydell shanmydell deleted the fix_make_docker_bug branch November 27, 2023 06:13
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants