Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests for Secret #428

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Update unit tests for Secret #428

merged 6 commits into from
Jan 29, 2025

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Jan 29, 2025

Description

Update unit tests for Secret

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@tdawe tdawe force-pushed the user/pooja/UTs-that-use-secret branch from 24b4b34 to b394c7f Compare January 29, 2025 15:18
@tdawe tdawe merged commit 0d5b5a3 into usr/spark/mount-credentials Jan 29, 2025
5 of 6 checks passed
@tdawe tdawe deleted the user/pooja/UTs-that-use-secret branch January 29, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@lukeatdell lukeatdell lukeatdell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdawe @bharathsreekanth @lukeatdell @kumarp20