Release 2.6.1 changes to main #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… current consumed size (#182) Set quota on target directory based on source actual size, not by consumed size Updated release version to 2.6.1
santhoshatdell
requested review from
donatwork,
harshaatdell and
ChristianAtDell
ChristianAtDell
approved these changes
Apr 17, 2023
santhoshatdell
requested review from
bpjain2004,
chimanjain,
meggm,
nitesh3108,
prablr79,
rajkumar-palani,
Sakshi-dell,
shefali-malhotra and
HarishH-DELL
as code owners
lukeatdell
approved these changes
Apr 20, 2023
| if err != nil { | ||
| return nil, status.Errorf(codes.Internal, "can't create volume quota %s", err.Error()) | ||
| if strings.Contains(err.Error(), "not found:") { | ||
| log.Info("Remote quota doesn't exist, create it") |
There was a problem hiding this comment.
Change 'create' to 'creating' to better describe what is happening. 'create it' sounds like the user should go and perform the action manually.
There was a problem hiding this comment.
Will correct the log texts in the next PR. There will be one soon for the improvements I have planned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging release-2.6.1 changes from PR #182 to main branch.
Release version has already been updated to 2.7.0 in the main branch. Updated 2.6.1 to 2.7.0 in other places to match with latest commit on the main branch.
GitHub Issues
List the GitHub issues impacted by this PR:
Please refer to PR #182 for the details.