Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse normalized snapshotID #237

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

mdutka-dell
Copy link
Contributor

@mdutka-dell mdutka-dell commented Jan 31, 2024

Description

  • bug fixing connected with parsing normalized snapshotID
  • writing additional unit tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1104

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
1) Package csi-powerscale/service
363 scenarios (363 passed)
1915 steps (1915 passed)
1m40.302991248s
godog finished
=== RUN   TestMkdirCreateDir
time="2024-02-14T05:21:45-05:00" level=debug   msg="created directory" file="/home/gosia/repos/csi-powerscale/service/mount.go:201"
--- PASS: TestMkdirCreateDir (0.00s)
=== RUN   TestMkdirExistingDir
--- PASS: TestMkdirExistingDir (0.00s)
=== RUN   TestMkdirExistingFile
--- PASS: TestMkdirExistingFile (0.00s)
PASS
coverage: 79.2% of statements
status 0
ok      github.com/dell/csi-isilon/v2/service   100.421s

2) Package csi-powerscale/common/utils
PASS
coverage: 45.9% of statements
ok      github.com/dell/csi-isilon/v2/common/utils      0.609s

Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link this PR to a GitHub issue. Thanks.

@mdutka-dell mdutka-dell requested a review from gallacher February 1, 2024 09:25
@mdutka-dell mdutka-dell changed the base branch from main to release-2.10.0 February 2, 2024 12:45
Copy link
Contributor

@cbartoszDell cbartoszDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdutka-dell mdutka-dell merged commit d55a851 into release-2.10.0 Feb 16, 2024
1 check failed
@mdutka-dell mdutka-dell deleted the delete_snapshot_id_parsing branch February 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants