Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Common Go Image #243

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Use Common Go Image #243

merged 1 commit into from
Feb 20, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Feb 19, 2024 •
edited
Loading

Description

Use Common go Image for building driver.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Sanity test
  • Build driver

@chimanjain chimanjain merged commit dc7bbc4 into main Feb 20, 2024
4 of 5 checks passed
@chimanjain chimanjain deleted the use-base-go-image branch February 20, 2024 10:48
cbartoszDell pushed a commit that referenced this pull request Mar 19, 2024
@chimanjain @cbartoszDell
use common go image (#243)
491fb7f
cbartoszDell pushed a commit that referenced this pull request Mar 19, 2024
@chimanjain @cbartoszDell
use common go image (#243)
6082d99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdutka-dell mdutka-dell mdutka-dell approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@atye atye Awaiting requested review from atye atye is a code owner

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@EmilyKatdell EmilyKatdell Awaiting requested review from EmilyKatdell

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chimanjain @nitesh3108 @mdutka-dell