Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golint removal #274

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Golint removal #274

merged 11 commits into from
Aug 20, 2024

Conversation

aqu-dell
Copy link
Contributor

@aqu-dell aqu-dell commented Aug 19, 2024

Description

Updating to golangci-lint in check shell script file and fixing linting errors from it

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1422

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested with make unit-test
  • Tested with make clean build

@santhoshatdell
Copy link
Contributor

santhoshatdell commented Aug 19, 2024

@arnchiequ-dell: There are file conflicts. Please resolve them.

@aqu-dell
Copy link
Contributor Author

@arnchiequ-dell: There are file conflicts. Please resolve them.

@santhoshatdell Fixed!

donatwork
donatwork previously approved these changes Aug 19, 2024
santhoshatdell
santhoshatdell previously approved these changes Aug 19, 2024
santhoshatdell
santhoshatdell previously approved these changes Aug 19, 2024
lukeatdell
lukeatdell previously approved these changes Aug 19, 2024
@chimanjain
Copy link
Contributor

can we remove golangci-lint from check.sh as we are running the same in GitHub actions.

@donatwork
Copy link
Contributor

I don't see coverage numbers being generated. Could you also add coverage generation. And set a threshold to the total coverage amount rounded to the lowest decimal.

@aqu-dell aqu-dell merged commit 15e1479 into main Aug 20, 2024
5 checks passed
@AronAtDell AronAtDell deleted the golint-removal branch October 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants