Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added make target to build without cache #278

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

francis-nijay
Copy link
Contributor

Description

Image build job fails because of no space left on the build machine. This is caused by overlay images created during the build process

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1448

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested build and there are no overlay containers left mounted on the build machine

@francis-nijay
Copy link
Contributor Author

image
Overlay containers are not present after the build id completed

docker.mk Outdated
Comment on lines 21 to 30
podman-build-no-cache: download-csm-common
$(eval include csm-common.mk)
@echo "Base Image is set to: $(DEFAULT_BASEIMAGE)"
@echo "Adding Driver dependencies to $(DEFAULT_BASEIMAGE)"
bash ./buildubimicro.sh $(DEFAULT_BASEIMAGE)
@echo "Base image build: SUCCESS" $(eval BASEIMAGE=localhost/csipowerscale-ubimicro:latest)
@echo "Building: $(REGISTRY)/$(IMAGENAME):$(IMAGETAG)"
@echo "Using Golang Image $(DEFAULT_GOIMAGE)"
$(BUILDER) build --no-cache -t "$(REGISTRY)/$(IMAGENAME):$(IMAGETAG)" -f Dockerfile.podman --target $(BUILDSTAGE) --build-arg GOPROXY=$(GOPROXY) --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the code duplication with something like this:

podman-build: download-csm-common
	$(eval include csm-common.mk)
	@echo "Base Image is set to: $(DEFAULT_BASEIMAGE)"
	@echo "Adding Driver dependencies to $(DEFAULT_BASEIMAGE)"
	bash ./buildubimicro.sh $(DEFAULT_BASEIMAGE)
	@echo "Base image build: SUCCESS" $(eval BASEIMAGE=localhost/csipowerscale-ubimicro:latest)
	@echo "Building: $(REGISTRY)/$(IMAGENAME):$(IMAGETAG)"
	@echo "Using Golang Image $(DEFAULT_GOIMAGE)"
	$(BUILDER) build $(NOCACHE) -t "$(REGISTRY)/$(IMAGENAME):$(IMAGETAG)" -f Dockerfile.podman --target $(BUILDSTAGE) --build-arg GOPROXY=$(GOPROXY) --build-arg BASEIMAGE=$(BASEIMAGE) --build-arg GOIMAGE=$(DEFAULT_GOIMAGE) .

podman-build-no-cache:
	@echo "Building with --no-cache ..."
	@make podman-build NOCACHE=--no-cache

@francis-nijay francis-nijay merged commit 651ba20 into main Sep 6, 2024
5 checks passed
@AronAtDell AronAtDell deleted the build-no-cache branch October 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants