Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/standalone helm installer #128

Merged
merged 9 commits into from
Jul 1, 2022
Merged

Conversation

harishp8889
Copy link
Collaborator

@harishp8889 harishp8889 commented Jun 29, 2022

Description

Updated helm installer by removing shell scripting and performing validations through helm itself

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#355

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on Kubernetes cluster

@harishp8889 harishp8889 self-assigned this Jun 29, 2022
@harishp8889 harishp8889 marked this pull request as ready for review June 29, 2022 10:42
@spriya-m
Copy link
Contributor

Please update the github issue.

@harishp8889
Copy link
Collaborator Author

Please update the github issue.

done

@harishp8889 harishp8889 merged commit cbadc22 into main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants