Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wwm matching failure on NVMe mounts. #346

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Sep 19, 2024

Description

Update to the PowerStore driver to use the gobrick with the NVMe matching fix for issue 1469. This issue prevents successful mounting of PowerStore devices when using the NVMe protocols.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1469

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Tested fix by reproducing problem in the lab then testing with new image and saw that the problem was resolved. More details of the fix in this pr

adarsh-dell
adarsh-dell previously approved these changes Sep 19, 2024
go.mod Outdated Show resolved Hide resolved
@donatwork donatwork merged commit 0e4a506 into main Sep 19, 2024
5 checks passed
@donatwork donatwork deleted the 1469_nvme_wwn_matching branch September 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants