-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metro volume expand support #350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeatdell
reviewed
Sep 30, 2024
lukeatdell
reviewed
Oct 3, 2024
lukeatdell
reviewed
Oct 3, 2024
lukeatdell
reviewed
Oct 3, 2024
4 tasks
santhoshatdell
changed the title
Adding support for volume expansion functionality on Metro volumes
Metro volume expand support
Oct 4, 2024
santhoshatdell
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell and
donatwork
as code owners
October 7, 2024 14:02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add more tests coverage the negative scenarios to increase code coverage?
lukeatdell
approved these changes
Oct 7, 2024
santhoshatdell
approved these changes
Oct 7, 2024
donatwork
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to document that e2e tests were developed and run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Tested expanding both regular and metro volume, and they succeeded.
Controller and node logs are attached to ticket 26867.
Node log for metro volume: